-
Notifications
You must be signed in to change notification settings - Fork 213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SPIKE: factor out Orch contract core-eval boilerplate #10695
Draft
dckc
wants to merge
21
commits into
master
Choose a base branch
from
dc-fu-autostart
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+480
−289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dckc
force-pushed
the
pc/fusdc-multichain-macro
branch
from
December 16, 2024 03:25
e084cac
to
4a1e603
Compare
0xpatrickdev
force-pushed
the
pc/fusdc-multichain-macro
branch
from
December 17, 2024 00:16
295e818
to
4ce1540
Compare
Factor out metainfo so that generic .start.js can get it without getting the whole contract.
reconsider ExtraCorePowers: infer from permit
dckc
force-pushed
the
dc-fu-autostart
branch
from
December 17, 2024 08:26
151c868
to
402792d
Compare
Deploying agoric-sdk with Cloudflare Pages
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs:
Description
Drive most of the core-eval code from
ContractMeta
andpermit
.permit.issuer.consume
permit.issuer.produce
meta.name
,permit.issuer.produce
,permit.brand.produce
meta.adminRoles
generalizes sending oracle invitationsorchPermit
,makePrivateArgs()
remains custom code, though only for stuff beyondorchestrationPowers
finishDeploy()
remains custom code: forpublishFeedPolicy
and callingcreatorFacet
methodspermit is down to ~15 LOC:
agoric-sdk/packages/fast-usdc/src/fast-usdc.contract.meta.js
Lines 84 to 98 in 151c868
In order to keep it type-safe,
meta
andpermit
are imported. Maybe there's a way to parameterize the types or something so that the custom code can call the boilerplate. hm.DRAFT until:
fast-usdc.start.js
toorch.start.js
and update builders, boot testsSecurity Considerations
This contributes somewhat to...
Scaling Considerations
n/a
Documentation Considerations
should simplify Writing a Core Eval Script to Deploy a Contract
Testing Considerations
For Fast USDC, existing tests should do it. It's essentially a pure refactor, but some of the filenames have runtime impact in builders and such, so it's possible that the changes are visible from tests.
Upgrade Considerations
This could / should make it less likely to mess up saving admin facets.